bug: fix duplicate dependency in effective model (fixes #2532)#2554
Merged
gnodet merged 2 commits intoapache:masterfrom Jul 2, 2025
Merged
bug: fix duplicate dependency in effective model (fixes #2532)#2554gnodet merged 2 commits intoapache:masterfrom
gnodet merged 2 commits intoapache:masterfrom
Conversation
… model fix - Add MavenITgh2532DuplicateDependencyEffectiveModelTest to verify the fix - Test reproduces the scenario where property placeholders in dependency coordinates caused duplicate dependency errors after interpolation - Verifies that deduplication now happens after interpolation as expected - Add test to TestSuiteOrdering for proper execution order
cstamas
approved these changes
Jul 2, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Jul 2, 2025
…pache#2554) * bug: fix duplicate dependency in effective model (fixes apache#2532) * Add integration test for apache#2532 duplicate dependency effective model fix - Add MavenITgh2532DuplicateDependencyEffectiveModelTest to verify the fix - Test reproduces the scenario where property placeholders in dependency coordinates caused duplicate dependency errors after interpolation - Verifies that deduplication now happens after interpolation as expected - Add test to TestSuiteOrdering for proper execution order (cherry picked from commit 7ac568b)
gnodet
added a commit
that referenced
this pull request
Jul 2, 2025
#2556) * bug: fix duplicate dependency in effective model (fixes #2532) * Add integration test for #2532 duplicate dependency effective model fix - Add MavenITgh2532DuplicateDependencyEffectiveModelTest to verify the fix - Test reproduces the scenario where property placeholders in dependency coordinates caused duplicate dependency errors after interpolation - Verifies that deduplication now happens after interpolation as expected - Add test to TestSuiteOrdering for proper execution order (cherry picked from commit 7ac568b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2532 where a project POM installation may fail.
This only happens if the same dependency is somehow defined once in a regular way and another time with a property placeholder. The reason is that the deduplication is wrongly done before interpolation.
Fixes #2532